Task bind native impl #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into task-bind-nativeImpl
TheSTL
reviewed
Oct 12, 2019
| while (someObj.hasOwnProperty(propKey)) { | ||
| propKey = Math.random().toString(); | ||
| } | ||
| someObj[propKey] = targetFunc; |
Member
There was a problem hiding this comment.
Can you use this line of code?
someObj.__proto__.propKey = targetFunc;
TheSTL
reviewed
Oct 12, 2019
| someObj[propKey] = targetFunc; | ||
|
|
||
| // prepend outer args to inner args | ||
| const result = someObj[propKey](...outerFuncArguments, ...innerFuncArgs); |
Member
There was a problem hiding this comment.
Can you use this line of code?
const result = someObj.propKey(...outerFuncArguments, ...innerFuncArgs);
TheSTL
reviewed
Oct 12, 2019
|
|
||
| // prepend outer args to inner args | ||
| const result = someObj[propKey](...outerFuncArguments, ...innerFuncArgs); | ||
| delete someObj[propKey]; |
Member
There was a problem hiding this comment.
delete someObj.__proto__.propKey;
TheSTL
requested changes
Oct 12, 2019
Member
TheSTL
left a comment
TheSTL
left a comment
There was a problem hiding this comment.
Changes are required because keyProps gets printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.